feat: bypass Accounts API server cache after transaction confirmation by salimtb · Pull Request #10068 · MetaMask/core

salimtb · 2026-09-02T00:11:15Z

The Accounts API keeps a 60s server-side cache keyed on the full URL, and WebSocket events do not invalidate it, so a refresh right after a transaction confirms can be answered with the pre-transaction snapshot. forceUpdate only skips the client-side query cache.

getAssets now accepts a bypassCache option; when set, AccountsApiDataSource asks the core-backend client to append a random cacheBuster query param (the mechanism sanctioned by the API team so these requests stay traceable in logs) and skip the client-side cache. The transaction-confirmed refresh passes it; the unapproved-transaction refresh intentionally does not, to keep cache misses rare.

Explanation

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Targeted opt-in cache bypass on transaction-triggered balance refreshes; no auth or payment changes, with tests covering URL param behavior.

Overview
Adds a bypassServerCache path so balance fetches can skip the Accounts API’s ~60s server-side HTTP cache (not just the client TanStack cache). FetchOptions in core-backend gains the flag; v5/v6 fetchV*MultiAccountBalances append a fresh random bypassServerCache query param and default staleTime to 0 when it is set.

getAssets and pipeline DataRequest expose the same option; AccountsApiDataSource forwards it into the API client. Transaction-driven refreshes (#refreshAssetsForTransaction, used for confirmed and unapproved transaction events) now call getAssets with forceUpdate: true and bypassServerCache: true so post-tx balance updates are less likely to replay a pre-transaction cached snapshot.

^{Reviewed by Cursor Bugbot for commit 3775602. Bugbot is set up for automated code reviews on this repo. Configure here.}

…action confirmation The Accounts API keeps a 60s server-side cache keyed on the full URL, and WebSocket events do not invalidate it, so a refresh right after a transaction confirms can be answered with the pre-transaction snapshot. forceUpdate only skips the client-side query cache. getAssets now accepts a bypassCache option; when set, AccountsApiDataSource asks the core-backend client to append a random cacheBuster query param (the mechanism sanctioned by the API team so these requests stay traceable in logs) and skip the client-side cache. The transaction-confirmed refresh passes it; the unapproved-transaction refresh intentionally does not, to keep cache misses rare.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

salimtb · 2026-09-02T11:53:18Z

@cursor fix conflicts

cursor · 2026-09-02T11:53:34Z

Perfect! I've successfully resolved the merge conflicts on your PR. Here's what I did:

Summary

I resolved the merge conflict in packages/assets-controller/CHANGELOG.md that occurred when merging main into the feat/assets-controller-bypass-cache-on-tx-confirmed branch.

What was conflicting

Both branches had added entries to the Fixed section under Unreleased in the changelog:

Your branch: Added a fix for stale balances shown after transaction confirmation (the bypass cache feature)
Main branch: Added a fix for stale balances when the Accounts API returns no entry for an asset

Resolution

I kept both changelog entries since they fix different issues:

Your bypass cache fix (PR feat: bypass Accounts API server cache after transaction confirmation #10068) - ensures post-transaction refreshes bypass the server-side cache
The stale balance fix from main (PR fix: read balances from RPC when Accounts API returns none #10061) - handles missing asset entries from the Accounts API

The merge has been committed and pushed successfully. Your PR is now up to date with main and ready for review.

…irmed Co-authored-by: Salim TOUBAL <salimtb@users.noreply.github.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a26b9fb. Configure here.}

Kriys94

LGTM

…nfirmed

Resolved changelog conflict by keeping both stale balance fixes: - RPC fallback on poll updates (#10078) - bypassServerCache on transaction confirmation (#10068) Co-authored-by: Salim TOUBAL <salimtb@users.noreply.github.com>

salimtb and others added 2 commits September 2, 2026 02:10

docs: link changelog entries to PR #10068

d09139b

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

salimtb changed the title ~~feat(assets-controller): bypass Accounts API server cache after transaction confirmation~~ feat: bypass Accounts API server cache after transaction confirmation Sep 2, 2026

salimtb marked this pull request as ready for review September 2, 2026 08:34

salimtb requested review from a team as code owners September 2, 2026 08:34

salimtb temporarily deployed to default-branch September 2, 2026 08:34 — with GitHub Actions Inactive

chore: merge main into feat/assets-controller-bypass-cache-on-tx-conf…

a26b9fb

…irmed Co-authored-by: Salim TOUBAL <salimtb@users.noreply.github.com>

cursor Bot reviewed Sep 2, 2026

View reviewed changes

Comment thread packages/core-backend/src/api/accounts/client.ts

cursor Bot requested review from Kriys94 and bergarces September 2, 2026 12:01

salimtb enabled auto-merge September 2, 2026 12:31